SHARD-1197: Refactor calculateAppReceiptDataHash #114
+20
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculateAppReceiptDataHash`, improve error handling, and remove data copying.
S0naliThakur
requested review from
aniketdivekar,
jintukumardas,
abdulazeem-tk4vr and
devendra-shardeum
…ts in correct validation state and update comments for clarity.
devendra-shardeum
requested review from
devendra-shardeum
and removed request for
devendra-shardeum
aniketdivekar
approved these changes
Dec 25, 2024
abdulazeem-tk4vr
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-1197/flaw-in-calculateappreceiptdatahash
Summary: Refactor app receipt data validation and hash calculation
validateAppReceiptDatato handle validation of app receipt data, improving code clarity and separation of concerns.calculateAppReceiptDataHashfunction to focus solely on hash calculation.